Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid string concat and regex inefficiency #117

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix: Avoid string concat and regex inefficiency #117

merged 3 commits into from
Nov 14, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Oct 31, 2023

This PR makes the following changes:

@rafvasq
Removes cmd line string concat
3764334 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Use possessive quantifier
8bec96f 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested review from pvaneck, ckadner and njhill October 31, 2023 17:15
@rafvasq rafvasq removed the request for review from pvaneck October 31, 2023 17:15
@rafvasq rafvasq marked this pull request as ready for review October 31, 2023 17:25
@rafvasq
Fixes command args
4379300 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq changed the title chore: Avoid string concat and regex inefficiency fix: Avoid string concat and regex inefficiency Nov 1, 2023
njhill
njhill approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq. Performance is not important in these contexts (readability should be the main thing). But the changes are fine with me if they suppress the warnings.

ckadner
ckadner approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ckadner,njhill,rafvasq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 8b36883 into kserve:main Nov 14, 2023
6 checks passed
@ckadner ckadner added this to the v0.11.2 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill approved these changes

@ckadner ckadner ckadner approved these changes

@tjohnson31415 tjohnson31415 Awaiting requested review from tjohnson31415

Assignees

@ckadner ckadner

Labels
approved lgtm
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rafvasq @kserve-oss-bot @ckadner @njhill